Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring mass fraction #2143

Conversation

satwik-kambham
Copy link
Contributor

@satwik-kambham satwik-kambham commented Oct 31, 2022

📝 Description

Type: 🚀 restructure

The initial mass fraction that will be read in will just be in IsotopeMassFraction dataframe which contains
A, Z, mass_fraction
for “stable” elements A = -1

@codecov
Copy link

codecov bot commented Oct 31, 2022

Codecov Report

Merging #2143 (3268459) into master (e3184f4) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master    #2143      +/-   ##
==========================================
+ Coverage   61.63%   61.65%   +0.01%     
==========================================
  Files          75       76       +1     
  Lines        8649     8692      +43     
==========================================
+ Hits         5331     5359      +28     
- Misses       3318     3333      +15     
Impacted Files Coverage Δ
tardis/model/base.py 90.60% <100.00%> (+0.26%) ⬆️
tardis/plasma/standard_plasmas.py 70.09% <0.00%> (-4.40%) ⬇️
tardis/plasma/properties/plasma_input.py 100.00% <0.00%> (ø)
tardis/plasma/properties/property_collections.py 100.00% <0.00%> (ø)
tardis/plasma/properties/rate_matrix_index.py 40.00% <0.00%> (ø)
tardis/io/util.py 80.50% <0.00%> (+2.51%) ⬆️

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@andrewfullard
Copy link
Contributor

@wkerzendorf we still want this I think

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants